Issue 300 in redis: redis-check-dump shows an overflowed value with huge .rdb.

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 296 by bjarni.runar: redis-cli does not handle EOF in monitor  
mode correctly
http://code.google.com/p/redis/issues/detail?id=296

What steps will reproduce the problem?
1. run redis-cli in monitor mode
2. killall redis-server

What is the expected output? What do you see instead?

redis-cli should exit, as the server is no longer running. It does not,  
instead it spews infinite newlines.


What version of the product are you using? On what operating system?

redis 2.0.0rc3


Please provide any additional information below.

Patch attached, fixes the issue.

Attachments:
	redis-cli-newlines.patch  798 bytes

Comment #1 on issue 276 by mvolmaro: [Feature Request] redis as embedded  
database
http://code.google.com/p/redis/issues/detail?id=276

Indeed. Having Redis available as embedded DB opens up a lot of  
possibilities that are not possible with the server only version.

Comment #1 on issue 299 by kickasspixels: Redis 2.0.1 RC 4 crashing
http://code.google.com/p/redis/issues/detail?id=299

Process:         redis-server [65443]
Path:            /usr/local/redis/redis-server
Identifier:      redis-server
Version:         ??? (???)
Code Type:       X86 (Native)
Parent Process:  launchd [1]

Date/Time:       2010-08-04 17:54:22.572 -0400
OS Version:      Mac OS X Server 10.5.8 (9L34)
Report Version:  6
Anonymous UUID:  0B57F7D5-CA9F-418D-B840-AD60267E68E1

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Crashed Thread:  0

Thread 0 Crashed:
0   libSystem.B.dylib                   0x9426ce42 __kill + 10
1   libSystem.B.dylib                   0x942df23a raise + 26
2   libSystem.B.dylib                   0x942eb679 abort + 73
3   redis-server                        0x0001f02f zmalloc_oom + 63
4   redis-server                        0x0001f0c6 zmalloc + 150
5   redis-server                        0x0001e646 sdsnewlen + 22
6   redis-server                        0x0000fdba  
rdbGenericLoadStringObject + 202
7   redis-server                        0x0000fe49  
rdbLoadEncodedStringObject + 25
8   redis-server                        0x00010195 rdbLoadObject + 837
9   redis-server                        0x0001b1ec rdbLoad + 348
10  redis-server                        0x0001c78e main + 334
11  redis-server                        0x00001ca6 start + 54

Thread 0 crashed with X86 Thread State (32-bit):
   eax: 0x00000000  ebx: 0x942eb639  ecx: 0xbffff5cc  edx: 0x9426ce42
   edi: 0x00000030  esi: 0xa05025b8  ebp: 0xbffff5e8  esp: 0xbffff5cc
    ss: 0x0000001f  efl: 0x00000282  eip: 0x9426ce42   cs: 0x00000007
    ds: 0x0000001f   es: 0x0000001f   fs: 0x00000000   gs: 0x00000037
   cr2: 0x03488000

Binary Images:
     0x1000 -    0x27fff +redis-server ??? (???)  
<e597b8f24768a19a6f450eeed5650e8c> /usr/local/redis/redis-server
0x8fe00000 - 0x8fe2db43  dyld 97.1 (???)
<458eed38a009e5658a79579e7bc26603>  
/usr/lib/dyld
0x91175000 - 0x9117cfe9  libgcc_s.1.dylib ??? (???)  
<f53c808e87d1184c0f9df63aef53ce0b> /usr/lib/libgcc_s.1.dylib
0x941fe000 - 0x94365ff3  libSystem.B.dylib ??? (???)  
<c8f52e158bf540cc000146ca8a705958> /usr/lib/libSystem.B.dylib
0x9746f000 - 0x97473fff  libmathCommon.A.dylib ??? (???)  
/usr/lib/system/libmathCommon.A.dylib
0xffff0000 - 0xffff1780  libSystem.B.dylib ??? (???)  
/usr/lib/libSystem.B.dylib

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 298 by rocklob: redis-cli "Error setting DB num" when  
authentication (-a) specified
http://code.google.com/p/redis/issues/detail?id=298

What steps will reproduce the problem?

1. Configure redis with these options:
      requirepass password
      databases 16
2. Start redis-server
3. Attempt to use redis-cli while specifying a database number other than 

0.  Example:
      redis-cli -n 1 -a password info

What is the expected output? What do you see instead?

      Output of info command should be shown.  Instead, you will see:
           Error setting DB num
           Error setting DB num

What version of the product are you using? On what operating system?

      Redis 1.2.6 on 64-bit RedHat EL 5.

Please provide any additional information below.

      In redis-cli.c, cliSendCommand() tries to call selectDb before it  
issues the AUTH command.

Comment #1 on issue 242 by flashjay: Possible memory leak
http://code.google.com/p/redis/issues/detail?id=242

hey,
is this problem fixed?

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 297 by theturtle32: WATCH command doesn't work
http://code.google.com/p/redis/issues/detail?id=297

What steps will reproduce the problem?
turtlelap:redis-2.0.0-rc4 turtle$ ./redis-cli
redis> set foo bar
OK
redis> get foo
"bar"
redis> watch foo
(error) ERR unknown command 'watch'
redis>


What version of the product are you using? On what operating system?
Redis 2.0.0-rc4, Mac OS X 10.6.4

Comment #2 on issue 266 by ben.nevile: Sorted set has not a same rank even
 
though it has a same score
http://code.google.com/p/redis/issues/detail?id=266

I understand the strict, academic definition of rank, but I don't believe 

it is a useful number to return in this context. I would be happy if you  
could provide me with a counter-example: why would someone using Redis
want  
to know the exact index of an element in the sorted set? Aren't we using  
Redis so that we can allow it to deal with that kind of data-structure  
detail?

I sumbit that it would be more helpful to have a command like kikiki.blue 

is requesting. Something like ZSCORERANK X, which when given element X
with  
score Y would return the number of elements with score greater than Y plus
 
one. Currently I am hacking this as follows with ZRANGEBYSCORE (node.js  
code):

redis.zrangebyscore(group_key,score+1,'+inf',function(err,reply){
   var rank = 1;
   if (reply) {
     //redis returns null for no matching elements
     rank = reply.toString().split(',').length + 1;
   }
   ...
})

This is fine, but I'm not looking forward to running this code on sorted  
sets with 100,000+ elements (a totally real use case, I'm using Redis for 

Facebook apps with hundreds of thousands of participants.)

Comment #5 on issue 211 by wilsonb: Feature request: ZREVRANGEBYSCORE
http://code.google.com/p/redis/issues/detail?id=211

I'll put in a $200 bounty on this feature. Anyone else in? (The $200 is  
yours if you implement this, even if nobody else is.)

Comment #4 on issue 288 by J4yferd: Guru Meditation crash every 1-2 days
http://code.google.com/p/redis/issues/detail?id=288

so for the meantime we have a cron job making sure it's up.

MONITOR has the strangest behavior when it crashes - it seems to output a 

bajillion newlines, which makes it really hard to find the last command.  

I've been trying to get that last line by redirecting the output to a log 

file, but after the crash, the log file was about 22M of gibberish.  It  
nearly crashed `less`.

I'll keep trying on my end, but let me know if there's any other info you 

guys need.

Comment #4 on issue 119 by pahowes: Unable to compile on Mac OS X Leopard 

(running on a PowerPC G4)
http://code.google.com/p/redis/issues/detail?id=119

The underlying problem is that redis.c is mucking around with the thread  
context and CPU registers, which of course is CPU-specific.  Here is the  
fix for redis-2.0.0-rc4:

1. edit redis.c
2. go to line 10838.
3. Change the "#else" to "#elsif defined (__i386__)"
4. Below line 10839 add the following:
     #else
       return (void*) uc->uc_mcontext->__ss.__srr0;

The final version should look like this:

     #if defined(_STRUCT_X86_THREAD_STATE64) && !defined(__i386__)
       return (void*) uc->uc_mcontext->__ss.__rip;
     #elif defined (__i386__)
       return (void*) uc->uc_mcontext->__ss.__eip;
     #else
       return (void*) uc->uc_mcontext->__ss.__srr0;
     #endif

You should now be able to compile with the following command:

     CFLAGS='-mmacosx-version-min=10.5 -arch i386 -arch x86_64 -arch ppc  
-sysroot=/Developer/SDKs/MacOSX10.5.sdk' make

Comment #5 on issue 231 by elreydetodo: Feature request: support for unix 

domain sockets
http://code.google.com/p/redis/issues/detail?id=231

I use Redis extensively in a very performance-critical application. I
would  
love to see Unix sockets available as well!

Comment #1 on issue 181 by jzawodn: master connect timeout neeed for  
replication SLAVEOF command to prevent DoS
http://code.google.com/p/redis/issues/detail?id=181

Adding to this, we were bitten again by this issue recently.

Ideally, I'd like two config file vars to help.  One would set the connect
 
timeout between a slave and its master (letting the OS decide waits far
too  
long!).  Secondly, being able to set the number of retries the slave will 

do will help to mitigate this as well.  In our environment,  I want the  
slave to have a 3 second connect timeout to the master and to try at most
3  
times before giving up.  Then our monitoring system can catch it and get a
 
human involved.

Otherwise, the slave is mostly unresponsive (long pauses in responses to  
other commands) while it's waiting for the timeout to fire during socket  
connection.

Comment #2 on issue 286 by ratman: set mykey "my binary safe value"    ...
 
will not work
http://code.google.com/p/redis/issues/detail?id=286

I have the same issue. On OSX 10.6.4, Redis 1.2.6 installed via 'brew'  
which pulled the archive:  
http://redis.googlecode.com/files/redis-1.2.6.tar.gz

I'm using double quotes but still get the error. Perhaps a bug catching
the  
quotes on OSX?

My exact output:

$ redis-cli
redis> set mykey "my binary safe value"
Wrong number of arguments for 'set'
redis>

Thanks to your replies, I finally installed a specific NGINX HTTP
instance with DAV module to take care of uploads.

As my first need was a sort of message queue with these blobs, I
exchange in a redis queue only previously uploaded NGINX URL.

Light, robust and fast.

Regards

Hey Fabien!

Bigdis it's just a toy currently, something that needs a lot of work
(and volunteers, as I need to focus on Redis itself ;) in order to be
a trusted/good solution.

So I suggest using Redis or another mature FS-based solution as
alternative.

Cheers,
Salvatore

On Mon, Jul 26, 2010 at 10:17 PM, Fabien <fabien.### @gmail.com>
wrote:
 Hi,

 I just discovered Bigdis :

 http://github.com/antirez/Bigdis/

 In the README, antirez wrote :

 

Hi Fabien,

Redis can be used for large values, but this causes Redis to spend a lot
of
time receiving SETs and sending replies back to the client, what can be
seen
as overhead. If this is the case, you should take a step back and see what
the problem is you're trying to solve. With your problem that involves
blobs
with an average size of 1MB, I would recommend not using Redis for serving
them for the simple reason that Redis is not designed to serve large
blobs.
There is no best-practice for a maximum record size, but if your problem
only involves working with the blobs as a whole (not parts, using commands
like APPEND), I would just stick to using a filesystem.

On another note, you not need to use /dev/shm because the OS will take
care
of caching on the fs-level. If your RAM is large enough to hold everything
you access frequently, it will be as speedy as /dev/shm.

Cheers,
Pieter

On Tue, Jul 27, 2010 at 8:11 PM, Jason J. W. Williams <
jasonjw### @gmail.com> wrote:

 Not related to this exactly, but I bet Bigdis performs well on
 Copy-on-Write filesystems.

 -J

 On Mon, Jul 26, 2010 at 2:17 PM, Fabien
<fabien### @gmail.com> wrote:
 > Hi,
 >
 > I just discovered Bigdis :
 >
 > http://github.com/antirez/Bigdis/
 >
 > In the README, antirez wrote :
 >
 >
 

Hi all,

One of the use case for redis has been to store hits/pageviews/counts.
Redis is good in that. However, how do you guys go about SORTING the
pageviews? Sorting in redis is still very slow, compare to the result
you can get from mysql, etc.

Appreciate your views on this.

Thx, let me try it

On Tue, Aug 3, 2010 at 8:43 AM, Damian Janowski
<djano### @dimaion.com> wrote:
 On Tue, Jul 27, 2010 at 2:21 PM, Edgar Gonzalez
<edgarg### @gmail.com> wrote:
> Hi Daniel,
>
> I'm experienced the same issue with redis-cli keys command
>
> do you find any workaround for this?

 I'm sorry about the delay.

 I think this fixes the issue:

http://github.com/djanowski/redis/com...a2657392c89ea4a28

 Unfortunately redis-cli doesn't have its own test suite, so I can
only
 tell you that I tested it manually and it worked.

 --
 

Thanks. I feel much safer now. :)

On Aug 3, 1:15 am, Salvatore Sanfilippo <ant### @gmail.com> wrote:
 On Tue, Aug 3, 2010 at 7:31 AM, trung <tr.### @phamcom.com>
wrote:
 > Hi,

 > I have a question about the list data structure in redis. Is
there a
 > size limit of the list?

 > I know that resque uses redis's list data structure, just
curious what
 > would have happen if a bunch of jobs start to back up. Will the
list
 > blow up because it's getting too big?

 It is guaranteed that a Redis list can be at least 2 billion of
 elements in all the archs.
 it's very hard to reach this limit in the real world, you'll likely
 end the RAM much faster.

 Cheers,
 Salvatore



 > Thanks.

 > --
 > 

It would be nice for the Redis Wiki to have a few graphs that show
performance of different functions (e.g. SET inserts) in relation to
the size of the collection.

For an example, see http://en.wikipedia.org/wiki/Trie.


On Aug 3, 11:15 am, Salvatore Sanfilippo <anti### @gmail.com> wrote:
 On Tue, Aug 3, 2010 at 7:31 AM, trung <tr### @phamcom.com>
wrote:
 > Hi,

 > I have a question about the list data structure in redis. Is
there a
 > size limit of the list?

 > I know that resque uses redis's list data structure, just
curious what
 > would have happen if a bunch of jobs start to back up. Will the
list
 > blow up because it's getting too big?

 It is guaranteed that a Redis list can be at least 2 billion of
 elements in all the archs.
 it's very hard to reach this limit in the real world, you'll likely
 end the RAM much faster.

 Cheers,
 Salvatore



 > Thanks.

 > --
 >