Re: Issue 303 in redis: Disk space full crashes redis-server (upon restart)

Updates:
	Status: Verified

Comment #4 on issue 97 by antirez: Ubuntu 9.10 /etc/init.d/redis-server  
[stop|restart] does not force a sync to disk
http://code.google.com/p/redis/issues/detail?id=97

this is now fixed (as Chris suggested)

Updates:
	Status: Verified

Comment #3 on issue 212 by pcnoordhuis: Interactive redis-cli crashes when
 
issuing a command after period of inactivity
http://code.google.com/p/redis/issues/detail?id=212

Reconnecting when the connection has timed out in interactive mode is
fixed  
in both 2.0 and master.

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 312 by themig.adx: redis-server hanging when being populated
with  
keys-values w/expire with VM enabled
http://code.google.com/p/redis/issues/detail?id=312

What steps will reproduce the problem?
1. Start redis-server with
    vm-enabled yes
    vm-max-memory 2147483648
    vm-page-size 32
    vm-pages 134217728
    etc
2. From a standalone executable issue commands in a loop that will do the 

following:
    getset random_key random_value
    expire random_key 2592000
3. When the server gets across boundary of its virtual machine (2 G)it  
stops responding to cli and to "redis-stat vmstat" with about 48% CPU busy
 
on our LINUX system, probably falling into a loopwhole of VM swapping.

What is the expected output? What do you see instead?


What version of the product are you using? On what operating system?


Please provide any additional information below.

Updates:
	Status: Verified

Comment #1 on issue 219 by antirez: With AOF fsyncing after every command 

redis-server can end up with partially applied transactions inside
dataset.
http://code.google.com/p/redis/issues/detail?id=219

This is now fixed, either the whole transaction or nothing will be written
 
in the AOF stream.

Thanks for reporting,
Salvatore

Updates:
	Status: Done

Comment #1 on issue 132 by antirez: Comment at the top of  
utils/redis-copy.rb applies to redis-sha1.rb
http://code.google.com/p/redis/issues/detail?id=132

done, thanks

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 313 by neophenix: Data entered while BGSAVE process is running  
may never be saved to disk
http://code.google.com/p/redis/issues/detail?id=313

server.dirty and server.lastsave are reset when the BGSAVE process exits. 
 
If during the time the process began and finished you add more keys (and  
then no more once the save is done), those keys will never be saved to
disk.

To reproduce requires some luck in timing this.  I am able to do it  
repeatedly on my mackbook pro, 7200rpm drive core i7.  Redis version is
the  
latest master.

save 60 1
vm-enabled yes

I have a script to insert 970,000 keys (1 - 970,000) with a simple value
of  
1.

Output from server while running looks like this:

[7587] 27 Aug 17:38:30 - DB 0: 903286 keys (0 volatile) in 1048576 slots
HT.
[7587] 27 Aug 17:38:30 - 1 clients connected (0 slaves), 113199888 bytes
in  
use
[7587] 27 Aug 17:38:32 * 1 changes in 60 seconds. Saving...
[7587] 27 Aug 17:38:32 * Background saving started by pid 7596
[7587] 27 Aug 17:38:35 - DB 0: 949844 keys (0 volatile) in 1048576 slots
HT.
[7587] 27 Aug 17:38:35 - 1 clients connected (0 slaves), 118908192 bytes
in  
use
[7587] 27 Aug 17:38:37 - Client closed connection
[7596] 27 Aug 17:38:38 * DB saved on disk
[7587] 27 Aug 17:38:38 * Background saving terminated with success
[7587] 27 Aug 17:38:40 - DB 0: 970000 keys (0 volatile) in 1048576 slots
HT.
[7587] 27 Aug 17:38:40 - 0 clients connected (0 slaves), 123198864 bytes
in  
use

Upon restart:

[7600] 27 Aug 17:39:55 * Using './redis.swap' as swap file
[7600] 27 Aug 17:39:55 * Allocating 8589934592 bytes of swap file
[7600] 27 Aug 17:39:55 * Swap file allocated with success
[7600] 27 Aug 17:39:55 - Allocated 16777216 bytes page table for 134217728
 
pages
[7600] 27 Aug 17:39:55 * Server started, Redis version 2.1.3
[7600] 27 Aug 17:40:01 * DB loaded from disk: 6 seconds
[7600] 27 Aug 17:40:01 * The server is now ready to accept connections on 

port 6379
[7600] 27 Aug 17:40:02 - DB 0: 912326 keys (0 volatile) in 1048576 slots
HT.
[7600] 27 Aug 17:40:02 - 0 clients connected (0 slaves), 120619760 bytes
in  
use


Attached is a patch against master to correct this.

Attachments:
	bgsave_fix.patch  1.1 KB

Updates:
	Status: Accepted

Comment #1 on issue 202 by antirez: Redis does not include man pages in
the  
upstream distribution (Github)
http://code.google.com/p/redis/issues/detail?id=202

Ok we should actually ping the author of this man pages and ask if we can 

include this in the Redis distribution... but then there is the problem of
 
a complex "make install" target that we are currently avoiding at all.

Anyway at least including the man pages makes sense. Accepted.

Cheers,
Salvatore

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 300 by hatemogi: redis-check-dump shows an overflowed value with
 
huge .rdb.
http://code.google.com/p/redis/issues/detail?id=300

What steps will reproduce the problem?
1. make a huge dump.rdb file.
2. run redis-check-dump with that file.
3. I see an overflowed value in the result.

What is the expected output? What do you see instead?

I see below

$ ls -la data/dump.rdb
-rw-rw-r--  1 dante dante 11853271020 Aug  5 15:24 data/dump.rdb
$ ./redis-check-dump data/dump.rdb
==== Processed 9971202 valid opcodes (in -1031630877 bytes)  

Comment #2 on issue 167 by antirez: Dissapointing responsiveness of Redis 

when using append only file mode
http://code.google.com/p/redis/issues/detail?id=167

updates about this:

1) With the current Linux kernel it is not possible to flush on a
different  
thread, as write(2) will block anyway in the main thread. This sucks but I
 
don't think this is going to get fixed in little time.
2) We have now in Redis master an option so that fsync(2) is not called  
when there is a background saving/log-rewrite operation in progress. It's
a  
trick... but works.
3) All this is highly dependent on the file system used and the mount  
options.
4) "fsync none" is a trivial way to completely fix this problem but the  
drawback is that up to 30 seconds of logs can be lost.
5) fsync always is now optimized, it is still very very slow but much  
faster than before.

I'm leaving this open as it's an open problem but I don't think there are 

very good way to fix this at the moment, still with the latest changes we 

mitigated the problem enough. Currently when very low latency is required
a  
two box setup with a saving slave may be the best option.

Updates:
	Status: Accepted

Comment #1 on issue 106 by antirez: Incorrect parsing of redis.conf save  
parameters
http://code.google.com/p/redis/issues/detail?id=106

yep not cool at all, accepted. I've some plan to rewrite most of the  
configuration file parsers and for sure sanity checks including parameters
 
types and limits will be supported as well.

Updates:
	Status: Verified

Comment #1 on issue 179 by antirez: redis-cli fails after error in  
multi/exec
http://code.google.com/p/redis/issues/detail?id=179

Fixed in redis master,

Cheers,
Salvatore

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 296 by bjarni.runar: redis-cli does not handle EOF in monitor  
mode correctly
http://code.google.com/p/redis/issues/detail?id=296

What steps will reproduce the problem?
1. run redis-cli in monitor mode
2. killall redis-server

What is the expected output? What do you see instead?

redis-cli should exit, as the server is no longer running. It does not,  
instead it spews infinite newlines.


What version of the product are you using? On what operating system?

redis 2.0.0rc3


Please provide any additional information below.

Patch attached, fixes the issue.

Attachments:
	redis-cli-newlines.patch  798 bytes

Updates:
	Status: WontFix

Comment #1 on issue 137 by antirez: redis.php: rpop and lpop method should
 
not have $value parameter
http://code.google.com/p/redis/issues/detail?id=137

please use Predis or Rediska PHP Redis libs! The old PHP lib is
deprecated.

Cheers,
Salvatore

Updates:
	Status: Verified

Comment #3 on issue 197 by antirez: Inconsistent? Handling of whitespace
in  
keys, at least in redis-cli
http://code.google.com/p/redis/issues/detail?id=197

This is now completely fixed, since Redis 2.0:


redis> set "any kind of key\n" foo
OK
redis> get "any kind of key\n"
"foo"

Closing :)
Salvatore

Updates:
	Status: Verified

Comment #3 on issue 168 by antirez: Feature Request] redis-cli needs a  
auth-option
http://code.google.com/p/redis/issues/detail?id=168

This was fixed indeed (see the -a option of redis-cli)

Comment #1 on issue 111 by antirez: [FEATURE REQUEST] read-only redis.conf
 
option
http://code.google.com/p/redis/issues/detail?id=111

not a bad idea indeed... I'll think a bit more about it but sounds cool

Comment #1 on issue 162 by antirez: need a redis-cli command to close all 

connection
http://code.google.com/p/redis/issues/detail?id=162

can't find a valid use case for this ;) Care to explain?

Cheers,
Salvatore

Updates:
	Status: Verified

Comment #5 on issue 203 by antirez: Redis doesn't disconnect when master  
goes down during replication
http://code.google.com/p/redis/issues/detail?id=203

The problem of this specific issue is now solved as the slave is now able 

to detect that the connection was closed, but there actually issue #181  
still open, I just commented there.

Thanks,
Salvatore

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 309 by everw### @gmail.com: would redis support plugins?
http://code.google.com/p/redis/issues/detail?id=309

Redis is an outstanding storage solution. High performance, atomic  
operations, data structures, replication, etc.

But it does not support transactions very well. The MULTI/EXEC mechanism
is  
too simple. It cannot handle complex situations. Data structures support
is  
somewhat limited.

I think, supporting complex operations and data structures with plugins
may  
be a better way, like stored procedures in RDB.

Actually, I'm working on this feature now.

Any comments?

Updates:
	Status: Invalid

Comment #4 on issue 147 by antirez: redis-cli should be able to connect to
 
slave
http://code.google.com/p/redis/issues/detail?id=147

(No comment was entered for this change.)