Re: Issue 97 in redis: Ubuntu 9.10 /etc/init.d/redis-server [stop|restart] does not force a sync to disk

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 300 by hatemogi: redis-check-dump shows an overflowed value with
 
huge .rdb.
http://code.google.com/p/redis/issues/detail?id=300

What steps will reproduce the problem?
1. make a huge dump.rdb file.
2. run redis-check-dump with that file.
3. I see an overflowed value in the result.

What is the expected output? What do you see instead?

I see below

$ ls -la data/dump.rdb
-rw-rw-r--  1 dante dante 11853271020 Aug  5 15:24 data/dump.rdb
$ ./redis-check-dump data/dump.rdb
==== Processed 9971202 valid opcodes (in -1031630877 bytes)  

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 296 by bjarni.runar: redis-cli does not handle EOF in monitor  
mode correctly
http://code.google.com/p/redis/issues/detail?id=296

What steps will reproduce the problem?
1. run redis-cli in monitor mode
2. killall redis-server

What is the expected output? What do you see instead?

redis-cli should exit, as the server is no longer running. It does not,  
instead it spews infinite newlines.


What version of the product are you using? On what operating system?

redis 2.0.0rc3


Please provide any additional information below.

Patch attached, fixes the issue.

Attachments:
	redis-cli-newlines.patch  798 bytes

Comment #1 on issue 276 by mvolmaro: [Feature Request] redis as embedded  
database
http://code.google.com/p/redis/issues/detail?id=276

Indeed. Having Redis available as embedded DB opens up a lot of  
possibilities that are not possible with the server only version.

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 302 by charpentier.claude: redis-cli cause  a seg fault on
netbsd  
X64
http://code.google.com/p/redis/issues/detail?id=302

What steps will reproduce the problem?
1. launch redis-cli compiled on NetBSD X64

What is the expected output? What do you see instead?
see attached files


What version of the product are you using? On what operating system?
I use redis 1.2.6 on NetBSD amd64 but works fine on i386

zat


Attachments:
	gistd2bd3b523a52d441132a-22c8b36a5c747b3f08eef4b2767193b9faa559bc.tar.gz 
 
849 bytes

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 309 by everw### @gmail.com: would redis support plugins?
http://code.google.com/p/redis/issues/detail?id=309

Redis is an outstanding storage solution. High performance, atomic  
operations, data structures, replication, etc.

But it does not support transactions very well. The MULTI/EXEC mechanism
is  
too simple. It cannot handle complex situations. Data structures support
is  
somewhat limited.

I think, supporting complex operations and data structures with plugins
may  
be a better way, like stored procedures in RDB.

Actually, I'm working on this feature now.

Any comments?

Comment #1 on issue 299 by kickasspixels: Redis 2.0.1 RC 4 crashing
http://code.google.com/p/redis/issues/detail?id=299

Process:         redis-server [65443]
Path:            /usr/local/redis/redis-server
Identifier:      redis-server
Version:         ??? (???)
Code Type:       X86 (Native)
Parent Process:  launchd [1]

Date/Time:       2010-08-04 17:54:22.572 -0400
OS Version:      Mac OS X Server 10.5.8 (9L34)
Report Version:  6
Anonymous UUID:  0B57F7D5-CA9F-418D-B840-AD60267E68E1

Exception Type:  EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Crashed Thread:  0

Thread 0 Crashed:
0   libSystem.B.dylib                   0x9426ce42 __kill + 10
1   libSystem.B.dylib                   0x942df23a raise + 26
2   libSystem.B.dylib                   0x942eb679 abort + 73
3   redis-server                        0x0001f02f zmalloc_oom + 63
4   redis-server                        0x0001f0c6 zmalloc + 150
5   redis-server                        0x0001e646 sdsnewlen + 22
6   redis-server                        0x0000fdba  
rdbGenericLoadStringObject + 202
7   redis-server                        0x0000fe49  
rdbLoadEncodedStringObject + 25
8   redis-server                        0x00010195 rdbLoadObject + 837
9   redis-server                        0x0001b1ec rdbLoad + 348
10  redis-server                        0x0001c78e main + 334
11  redis-server                        0x00001ca6 start + 54

Thread 0 crashed with X86 Thread State (32-bit):
   eax: 0x00000000  ebx: 0x942eb639  ecx: 0xbffff5cc  edx: 0x9426ce42
   edi: 0x00000030  esi: 0xa05025b8  ebp: 0xbffff5e8  esp: 0xbffff5cc
    ss: 0x0000001f  efl: 0x00000282  eip: 0x9426ce42   cs: 0x00000007
    ds: 0x0000001f   es: 0x0000001f   fs: 0x00000000   gs: 0x00000037
   cr2: 0x03488000

Binary Images:
     0x1000 -    0x27fff +redis-server ??? (???)  
<e597b8f24768a19a6f450eeed5650e8c> /usr/local/redis/redis-server
0x8fe00000 - 0x8fe2db43  dyld 97.1 (???)
<458eed38a009e5658a79579e7bc26603>  
/usr/lib/dyld
0x91175000 - 0x9117cfe9  libgcc_s.1.dylib ??? (???)  
<f53c808e87d1184c0f9df63aef53ce0b> /usr/lib/libgcc_s.1.dylib
0x941fe000 - 0x94365ff3  libSystem.B.dylib ??? (???)  
<c8f52e158bf540cc000146ca8a705958> /usr/lib/libSystem.B.dylib
0x9746f000 - 0x97473fff  libmathCommon.A.dylib ??? (???)  
/usr/lib/system/libmathCommon.A.dylib
0xffff0000 - 0xffff1780  libSystem.B.dylib ??? (???)  
/usr/lib/libSystem.B.dylib

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 298 by rocklob: redis-cli "Error setting DB num" when  
authentication (-a) specified
http://code.google.com/p/redis/issues/detail?id=298

What steps will reproduce the problem?

1. Configure redis with these options:
      requirepass password
      databases 16
2. Start redis-server
3. Attempt to use redis-cli while specifying a database number other than 

0.  Example:
      redis-cli -n 1 -a password info

What is the expected output? What do you see instead?

      Output of info command should be shown.  Instead, you will see:
           Error setting DB num
           Error setting DB num

What version of the product are you using? On what operating system?

      Redis 1.2.6 on 64-bit RedHat EL 5.

Please provide any additional information below.

      In redis-cli.c, cliSendCommand() tries to call selectDb before it  
issues the AUTH command.

Comment #11 on issue 71 by kkirancse: [Feature Request] SSL Support
http://code.google.com/p/redis/issues/detail?id=71

Hi guys,

i couldn't use redis in my company just because there is no SSL  
communication support. I feel it adds value.

Updates:
	Status: Fixed

Comment #18 on issue 65 by antirez: [Feature Request] Blocking LPOP
http://code.google.com/p/redis/issues/detail?id=65

this was implemented time ago, closing the issue...

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 306 by jacob.bay.hansen: [Feature request] Sorted Set and Set  
intersections
http://code.google.com/p/redis/issues/detail?id=306

I would like to be able to do intersections on sets and a score- or  
rank-limited sorted sets.

Assume that we have some sorted sets:

* users:activity {timestamp, userid}
* users:age {age, userid}

And some sets

* users:male {userid}

It would be nice to be able to do something like (syntax not supposed to
be  
redis):

     users:activity by rank 0 to 100 INTERSECT users:age by score
<18> to  
+inf  INTERSECT users:male

Not sure how this could be expressed without changing the current syntax  
too much, perhaps using an extension to ZRANGE a la:

     ZSTORERANGE dstkey key start end   #Store a sorted set range (by
rank)  
as a set
     ZSTORERANGEBYSCORE dstkey key min max #Store a sorted set range (by  
score) as a set

That would mean that I could do my intersection as:

     INCR i
     ZSTORERANGE tmp:<i>:activity users:activity 0 100
     ZSTORERANGEBYSCORE tmp:<i>:age users:age 18 +inf
     SINTER tmp:<i>:activity tmp:<i>:age users:male
     DEL tmp:<i>:activity
     DEL tmp:<i>:age

I realize that this requires a few calls to redis; but I thinks it is  
preferable to having to transport the sets back and forth to do the  
intersection.

What do you think?

- Jake

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 310 by VnVi### @gmail.com: [Feature Request] Add multiple values 

to set
http://code.google.com/p/redis/issues/detail?id=310

I often need to get intersected ids, and then sort those ids. In my app,  
because the ids are stored in different sets and zsets, I can't use SINTER
 
or ZINTERSTORE on them. Instead I get all ids from those sets and zsets
and  
perform the intersection at the application level (using function  
array_intersect() in PHP). But I need to sort the ids in redis (need to  
sort BY a hash field). So I have to add the intersected ids to a temporary
 
set to do a SORT command against it. I use SADD in a loop to accomplish  
this. However from my test using Predis lib, adding 100,000 integer values
 
to a set by using a loop takes 7 seconds, which is surely slow. I think  
there should be a way to add multiple values to a set in one go.

I test setting 100,000 keys/values with MSET (also using Predis) and it  
only takes about 1 second. So I think a MSADD or something like that would
 
be just about as fast. And while we can set multiple string values I think
 
it's logical to have a command to add multiple values to a set. Beside my 

case, I can think of a number of other cases where this command is useful.

Thanks

Comment #1 on issue 242 by flashjay: Possible memory leak
http://code.google.com/p/redis/issues/detail?id=242

hey,
is this problem fixed?

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 307 by john2do: performance on centos?
http://code.google.com/p/redis/issues/detail?id=307

simple test get me stuck)

on centos 5.5 x64 (2.6.18 from dist or generic 2.6.35.1), latest version  
compiled from sources:
./redis-benchmark -n 100000 -d 10 -q
PING: 45423.25 requests per second
PING (multi bulk): 46585.93 requests per second
SET: 48084.62 requests per second
GET: 47552.55 requests per second
INCR: 47241.85 requests per second
CPU0: Intel(R) Xeon(R) CPU           X5450  @ 3.00GHz stepping 06

ubuntu 10 x64:
./redis-benchmark -n 100000 -d 10 -q
PING: 80906.96 requests per second
PING (multi bulk): 84907.47 requests per second
SET: 83893.45 requests per second
GET: 81315.45 requests per second
INCR: 84537.62 requests per second
CPU0: Intel(R) Celeron(R) CPU        E3300  @ 2.50GHz stepping 0a

any help?

Updates:
	Status: Verified

Comment #5 on issue 93 by antirez: Remove list when it's empty
http://code.google.com/p/redis/issues/detail?id=93

This was fixed time ago and for all the available types.

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 297 by theturtle32: WATCH command doesn't work
http://code.google.com/p/redis/issues/detail?id=297

What steps will reproduce the problem?
turtlelap:redis-2.0.0-rc4 turtle$ ./redis-cli
redis> set foo bar
OK
redis> get foo
"bar"
redis> watch foo
(error) ERR unknown command 'watch'
redis>


What version of the product are you using? On what operating system?
Redis 2.0.0-rc4, Mac OS X 10.6.4

Comment #5 on issue 211 by wilsonb: Feature request: ZREVRANGEBYSCORE
http://code.google.com/p/redis/issues/detail?id=211

I'll put in a $200 bounty on this feature. Anyone else in? (The $200 is  
yours if you implement this, even if nobody else is.)

Updates:
	Status: WontFix

Comment #6 on issue 56 by antirez: Request: synchronous replication
http://code.google.com/p/redis/issues/detail?id=56

Hello, the idea is that this use case should be solver by Redis cluster  
that will be in short time our main focus.

Comment #2 on issue 266 by ben.nevile: Sorted set has not a same rank even
 
though it has a same score
http://code.google.com/p/redis/issues/detail?id=266

I understand the strict, academic definition of rank, but I don't believe 

it is a useful number to return in this context. I would be happy if you  
could provide me with a counter-example: why would someone using Redis
want  
to know the exact index of an element in the sorted set? Aren't we using  
Redis so that we can allow it to deal with that kind of data-structure  
detail?

I sumbit that it would be more helpful to have a command like kikiki.blue 

is requesting. Something like ZSCORERANK X, which when given element X
with  
score Y would return the number of elements with score greater than Y plus
 
one. Currently I am hacking this as follows with ZRANGEBYSCORE (node.js  
code):

redis.zrangebyscore(group_key,score+1,'+inf',function(err,reply){
   var rank = 1;
   if (reply) {
     //redis returns null for no matching elements
     rank = reply.toString().split(',').length + 1;
   }
   ...
})

This is fine, but I'm not looking forward to running this code on sorted  
sets with 100,000+ elements (a totally real use case, I'm using Redis for 

Facebook apps with hundreds of thousands of participants.)

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 305 by Felix.zema: [Feature Request] Increment/decrement with  
value limit
http://code.google.com/p/redis/issues/detail?id=305

Atomic incr/decr is a nice feature, but imagine a situation when multiple 

clients increment a key and maximum allowed value is 100.
To enforce that rule we need to get that key, compute the difference and  
increment by that difference, all using watch/multi/exec.

My proposition is to add an optional parameter to incr/decr commands which
 
would limit the value of key after incrementation:
INCRBY key integer [limit]
DECRBY key integer [limit]

And sample usage:
 INCRBY key 15 16
15
 INCRBY key 1 16
16
 INCRBY key 2 16
16
 INCRBY key 7
23
 DECRBY key 10 14
14
 INCRBY key 6 10
10

Updates:
	Status: Verified

Comment #7 on issue 94 by antirez: Master does not authenticate to slaves 

before replication.
http://code.google.com/p/redis/issues/detail?id=94

(No comment was entered for this change.)