apache tuning for svn

Hi All,

I noticed using Firefox with a plugin yslow that it recommends using only
4 virtual hosts instead of the 16 I have for serving images. I am using a 6
core system and want to make sure I take advantage of it using Apache APR
so I setup more than 4 virtual hosts.

I am using multiple virtual hosts for serving images since I heard that
can improve user response time where they have browsers with 4 or more
concurrent connections supported. I have a screenshots page where I have 24
thumbnails being loaded into the browser and I am trying to tune APR for
the best user response time.

So any best practice for this you all would recommend?

Thanks,
-Tony


      

Weijunli,

I also have an environment that has similar very large datasets with
strict
latency.  Can you please elaborate on the custom changes you added to
cassandra to meet these sla, either code or configuration.  i am very
interested in learning more about the internal workings of cassandra and
performance.

Thanx,
Artie

On Thu, May 6, 2010 at 10:06 AM, Weijun Li <weiju### @gmail.com>
wrote:

 Our use case is a little different: our server is a typical high
volume
 transaction server that processes more than half billion requests per
day.
 The write/read ratio is close to 1, and the cluster needs to serve
10k
 write+read with strict latency (<20ms) otherwise the client will
treat it as
 failure. Plus we have hundreds of millions of keys so the generated
sstable
 files are much bigger that the ram size. In this case using mmap will
cause
 Cassandra to use sometimes > 100G virtual memory which is much
more than the
 physical ram, since we are using random partitioner the OS will be
busy
 doing swap.

 I have finally customized cassandra to meet the above requirement by
using
 cheap hardware (32G ram + SATA drives): one thing I learned is that
you have
 to carefully avoid swapping, especially when you need to cache most
of the
 keys in memory, swap can easily damage the performance of your in
memory
 cache. I also made some optimizations to reduce memory/disk
consumption and
 to make it easier for us to diagnose issues. In one word: cassandra
is very
 well written but there's still huge potential for you to improve it
to meet
 your special requirements.

 -Weijun


 On Wed, May 5, 2010 at 9:43 AM, Jordan Pittier
<jordan.p### @gmail.com>wrote:

> I disagree. Swapping could be avoided. I don't know Cassandra
internals
> mechanisms but what I am expecting is that whenever I want to
read rows that
> are not in RAM, Cassandra load them from hard drive to RAM if
space is
> available, and, if RAM is full to reply my query without saving
rows in RAM.
> No need for swapping.
>
> I have no try yet to change DiskAccessMode to standard, I hope it
will
> help me.
>
> Another thing : please dont post your benchmark figures without
any
> explanation on the work load generator or your cluster settings.
It really
> doesn't make any sense...
>
>
> On Wed, May 5, 2010 at 6:16 PM, Weijun Li
<weij### @gmail.com> wrote:
>
>> When you have much more data than you can hold in memory, it
will be
>> difficult for you to get around of swap which will most
likely ruin your
>> performance. Also in this case mmap doesn't seem to make much
sense if you
>> use random partitioner which will end up with crazy swap too.
However we
>> found a way to get around read/write performance issue by
integrating
>> memcached into Cassandra: in this case you need to ask
memcached to disable
>> disk swap so you can achieve move than 10k read+write with
milli-second
>> level of latency. Actually this is the only way that we
figured out that can
>> gracefully solve the performance and memory issue.
>>
>> -Weijun
>>
>>
>> On Wed, May 5, 2010 at 8:19 AM, Ran Tavory
<rant### @gmail.com> wrote:
>>
>>> I'm still trying to figure out where my slowness is
coming from...
>>> By now I'm pretty sure it's the reads are slow, but not
sure how to
>>> improve them.
>>>
>>> I'm looking at cfstats. Can you say if there are better
configuration
>>> options? So far I've used all default settings, except
for:
>>>
>>>     <Keyspace Name="outbrain_kvdb">
>>>       <ColumnFamily CompareWith="BytesType"
Name="KvImpressions"
>>> KeysCached="50%"/>
>>>
>>> 
<ReplicaPlacementStrategy>org.apache.cassandra.locator.RackAwareStrategy</ReplicaPlacementStrategy>
>>>      
<ReplicationFactor>2</ReplicationFactor>
>>>
>>> 
<EndPointSnitch>org.apache.cassandra.locator.EndPointSnitch</EndPointSnitch>
>>>     </Keyspace>
>>>
>>>
>>> What does a good read latency look like? I was expecting
10ms, however
>>> so far it seems that my KvImpressions read latency is
30ms and in the system
>>> keyspace I have 800ms :(
>>> I thought adding KeysCached="50%" would improve my
situation but
>>> unfortunately looks like the hitrate is about 0. I
realize that's
>>> application specific, but maybe there are other magic
bullets...
>>>
>>> Is there something like adding cache to the system
keyspace? 800 ms is
>>> pretty bad, isn't it?
>>>
>>> See stats below and thanks.
>>>
>>>
>>> Keyspace: outbrain_kvdb
>>>         Read Count: 651668
>>>         Read Latency: 34.18622328547666 ms.
>>>         Write Count: 655542
>>>         Write Latency: 0.041145092152752985 ms.
>>>         Pending Tasks: 0
>>>                 Column Family: KvImpressions
>>>                 SSTable count: 13
>>>                 Space used (live): 23304548897
>>>                 Space used (total): 23304548897
>>>                 Memtable Columns Count: 895
>>>                 Memtable Data Size: 2108990
>>>                 Memtable Switch Count: 8
>>>                 Read Count: 468083
>>>                 Read Latency: 151.603 ms.
>>>                 Write Count: 552566
>>>                 Write Latency: 0.023 ms.
>>>                 Pending Tasks: 0
>>>                 Key cache capacity: 17398656
>>>                 Key cache size: 567967
>>>                 Key cache hit rate: 0.0
>>>                 Row cache: disabled
>>>                 Compacted row minimum size: 269
>>>                 Compacted row maximum size: 54501
>>>                 Compacted row mean size: 933
>>> ...
>>> 

Hi,

I'm using Tomcat 6.0.26, Java 1.6 and wondering what tools/strategies you
use to tune your garbage collection parameters?

Further, does anyone know how to read entries in the garbage collection
log? 
Entries in my log look like

Desired survivor size 10944512 bytes, new threshold 1 (max 15)
 [PSYoungGen: 129311K->3232K(136512K)] 558882K->434085K(585920K),
0.0090900
secs]

Thanks, - Dave

Author: markt
Date: Thu Jul  1 09:35:23 2010
New Revision: 959568

URL: http://svn.apache.org/viewvc?rev=959568&view=rev
Log:
Improve handling for method invocation in EL, in particular the method
used to identify the method to invoke. This reverts r953440 and implements
a more comprehensive solution.
The method identification code attempts to mimic how the Java compiler
works. In a few cases it finds methods where the Java complier reports an
ambiguous method. The EL spec is sufficiently vague on method selection
that I don't think this will be an issue.

Added:
    tomcat/trunk/test/org/apache/el/TesterBeanAA.java   (with props)
    tomcat/trunk/test/org/apache/el/TesterBeanAAA.java   (with props)
    tomcat/trunk/test/org/apache/el/TesterBeanBBB.java   (with props)
    tomcat/trunk/test/org/apache/el/TesterBeanC.java   (with props)
Modified:
    tomcat/trunk/java/org/apache/el/ExpressionFactoryImpl.java
    tomcat/trunk/java/org/apache/el/Messages.properties
    tomcat/trunk/java/org/apache/el/lang/ExpressionBuilder.java
    tomcat/trunk/java/org/apache/el/parser/AstValue.java
    tomcat/trunk/java/org/apache/el/util/ReflectionUtil.java
    tomcat/trunk/test/org/apache/el/TestMethodExpressionImpl.java
    tomcat/trunk/test/org/apache/el/TesterBeanA.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/el/ExpressionFactoryImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/t...568&view=diff

Author: markt
Date: Thu Jul  8 21:28:21 2010
New Revision: 961947

URL: http://svn.apache.org/viewvc?rev=961947&view=rev
Log:
Test case for https://issues.apache.org/bugzilla/show_bug.cgi?id=49555
Fix to follow shortly

Added:
    tomcat/trunk/test/webapp-3.0/bug49555.jsp   (with props)
Modified:
    tomcat/trunk/test/org/apache/el/TestELInJsp.java
    tomcat/trunk/test/org/apache/el/TesterFunctions.java
    tomcat/trunk/test/webapp-3.0/WEB-INF/bugs.tld

Modified: tomcat/trunk/test/org/apache/el/TestELInJsp.java
URL:
http://svn.apache.org/viewvc/tomcat/t...947&view=diff

Modified: tomcat/trunk/webapps/docs/config/filter.xml
URL:
http://svn.apache.org/viewvc/tomcat/t...219&view=diff

Author: markt
Date: Wed Jul 14 22:11:30 2010
New Revision: 964219

URL: http://svn.apache.org/viewvc?rev=964219&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48998
Add the ExpiresFilter, a port of mod_expires
Patch provided by Cyrille Le Clerc

Added:
    tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java  
(with props)
    tomcat/trunk/test/org/apache/catalina/filters/TestExpiresFilter.java  
(with props)
Modified:
    tomcat/trunk/java/org/apache/catalina/filters/LocalStrings.properties
    tomcat/trunk/webapps/docs/changelog.xml
    tomcat/trunk/webapps/docs/config/filter.xml

Added: tomcat/trunk/java/org/apache/catalina/filters/ExpiresFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/t...219&view=auto

Author: sf
Date: Sun Jun 27 19:51:28 2010
New Revision: 958413

URL: http://svn.apache.org/viewvc?rev=958413&view=rev
Log:
Add test for per-dir loglevels

Added:
    httpd/test/framework/trunk/t/apache/loglevel.t
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/core_crit/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/core_crit/info.html  
(with props)
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/core_info/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/core_info/info.html  
(with props)
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/crit/
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/crit/core_info/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/crit/core_info/crit/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/crit/core_info/crit/info.html
  (with props)
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/info/
    httpd/test/framework/trunk/t/htdocs/apache/loglevel/info/core_crit/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/info/core_crit/info/
   
httpd/test/framework/trunk/t/htdocs/apache/loglevel/info/core_crit/info/info.html
  (with props)
Modified:
    httpd/test/framework/trunk/t/conf/extra.conf.in

Added: httpd/test/framework/trunk/t/apache/loglevel.t
URL:
http://svn.apache.org/viewvc/httpd/te...413&view=auto

Author: markt
Date: Thu Jul 29 20:53:26 2010
New Revision: 980567

URL: http://svn.apache.org/viewvc?rev=980567&view=rev
Log:
Add optional support to the HTML Manager application to display Proxy
sessions. It is disabled by default.

Added:
    tomcat/trunk/java/org/apache/catalina/manager/DummyProxySession.java  
(with props)
Modified:
    tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
    tomcat/trunk/java/org/apache/catalina/manager/HTMLManagerServlet.java
    tomcat/trunk/java/org/apache/catalina/manager/JspHelper.java
    tomcat/trunk/java/org/apache/catalina/manager/util/SessionUtils.java
    tomcat/trunk/webapps/docs/changelog.xml
    tomcat/trunk/webapps/manager/WEB-INF/jsp/sessionsList.jsp
    tomcat/trunk/webapps/manager/WEB-INF/web.xml

Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/BackupManager.java
URL:
http://svn.apache.org/viewvc/tomcat/t...567&view=diff

Author: markt
Date: Sat Jul 10 21:13:23 2010
New Revision: 962917

URL: http://svn.apache.org/viewvc?rev=962917&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49478
Add support for user specified character sets to the
AddDefaultCharsetFilter. Based on a patch by Felix Schumacher.

Added:
   
tomcat/trunk/test/org/apache/catalina/filters/TestAddCharSetFilter.java  
(with props)
Modified:
   
tomcat/trunk/java/org/apache/catalina/filters/AddDefaultCharsetFilter.java
    tomcat/trunk/java/org/apache/catalina/filters/LocalStrings.properties
    tomcat/trunk/webapps/docs/changelog.xml
    tomcat/trunk/webapps/docs/config/filter.xml

Modified:
tomcat/trunk/java/org/apache/catalina/filters/AddDefaultCharsetFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/t...917&view=diff

Author: markt
Date: Fri Jul 23 14:30:26 2010
New Revision: 967107

URL: http://svn.apache.org/viewvc?rev=967107&view=rev
Log:
Handle the edge cases where resources packaged in JARs have names that
start with a single quote character or a double quote character.

Added:
    tomcat/trunk/test/org/apache/naming/resources/TestWarDirContext.java  
(with props)
    tomcat/trunk/test/webapp-3.0-fragments/'singlequote2.jsp   (with
props)
    tomcat/trunk/test/webapp-3.0-fragments/WEB-INF/classes/
    tomcat/trunk/test/webapp-3.0-fragments/warDirContext.jsp   (with
props)
Modified:
    tomcat/trunk/java/org/apache/naming/resources/WARDirContext.java
    tomcat/trunk/test/webapp-3.0-fragments/WEB-INF/lib/resources.jar
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/naming/resources/WARDirContext.java
URL:
http://svn.apache.org/viewvc/tomcat/t...107&view=diff

Author: jfclere
Date: Tue Jun 29 14:07:23 2010
New Revision: 958977

URL: http://svn.apache.org/viewvc?rev=958977&view=rev
Log:
Arrange filter logic. Back port of r958911.

Modified:
   
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
   
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
   
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11Processor.java
   
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/filters/BufferedInputFilter.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/Http11AprProcessor.java
URL:
http://svn.apache.org/viewvc/tomcat/t...977&view=diff

Hi OSGi folks,

Sorry to bother you with a question that may not be really for this
mailing list. I've tried into ActiveMQ users list without success.
I'd like to know if anyone here was able to run ActiveMQ 5.3.2 under
Karaf?
I've used:
features:addUrl
mvn:org.apache.activemq/activemq-karaf/5.3.2/xml/features to install it
but keep getting :
ERROR | Timer-0          |
WaiterApplicationContextExecutor | WaiterApplicationContextExecutor  432
| Unable to create application context for [alerts-broker.xml],
unsatisfied dependencies: Dependency on
[(objectClass=javax.transaction.TransactionManager)] (from bean
[&transactionManager])

Even thought all required bundles are installed and correctly started.

Sorry again,
--Daoud.

I know Chris Custine has done some work a while back, just wondering is
there was any interest in using Karaf for the base runtime ?  If so, i'd
be
happy to help in any way.  I certainly don't want to push Karaf at all
costs, just proposing / checking ... so I would not be offended if the
answer is no ;-)

For those who don't know Karaf, you can find some informations at
http://felix.apache.org/site/apache-felix-karaf.html
The goal of Karaf is to be a base runtime container for OSGi based server
applications.  It's currently used in ServiceMix, Geronimo and should be
used in ActiveMQ in its next major release.

Author: markt
Date: Wed Jun  9 14:30:30 2010
New Revision: 953025

URL: http://svn.apache.org/viewvc?rev=953025&view=rev
Log:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48379
Make session cookie name, domain and path configurable per context

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/Context.java
   
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
   
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
   
tomcat/tc6.0.x/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
    tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/t...025&view=diff

Author: kkolinko
Date: Sun Jun  6 19:17:58 2010
New Revision: 951930

URL: http://svn.apache.org/viewvc?rev=951930&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=48971
Make stopping of leaking Timer threads optional and disabled by default.
It is merge of r950164, r950614 from trunk.

Modified:
    tomcat/tc6.0.x/trunk/   (props changed)
    tomcat/tc6.0.x/trunk/STATUS.txt
   
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardContext.java
   
tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/WebappClassLoader.java
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/loader/WebappLoader.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
    tomcat/tc6.0.x/trunk/webapps/docs/config/context.xml

Propchange: tomcat/tc6.0.x/trunk/

Hi,

I'm moving the Fuse Camel examples from camel 1.6 to 2.2. In the
example, there is an exercice where we create a custom FileComponent.
I have been able to deploy the OSGI bundle but when I start the route
using this component, I get this error :

18:39:56,609 | ERROR | xtenderThread-12 | ContextLoaderListener
    | BundleApplicationContextListener   50 | Application context
refresh failed
(OsgiBundleXmlApplicationContext(bundle=com.fusesource.camel-exercises-custom-file-component-route,
config=osgibundle:/META-INF/spring/*.xml))
org.apache.camel.RuntimeCamelException: java.lang.ClassCastException:
Not instanceof org.apache.camel.TypeConverter value:
org.apache.camel.converter### @1474c1f
	at
org.apache.camel.util.ObjectHelper.wrapRuntimeCamelException(ObjectHelper.java:1055)
	at
org.apache.camel.impl.DefaultCamelContext.getTypeConverter(DefaultCamelContext.java:693)
	at
org.apache.camel.impl.DefaultCamelContext.forceLazyInitialization(DefaultCamelContext.java:1211)
	at
org.apache.camel.impl.DefaultCamelContext.doStartCamel(DefaultCamelContext.java:1083)
	at
org.apache.camel.impl.DefaultCamelContext.doStart(DefaultCamelContext.java:1020)
	at
org.apache.camel.spring.SpringCamelContext.doStart(SpringCamelContext.java:158)
	at org.apache.camel.impl.ServiceSupport.start(ServiceSupport.java:53)
	at
org.apache.camel.impl.DefaultCamelContext.start(DefaultCamelContext.java:898)
	at
org.apache.camel.spring.SpringCamelContext.maybeStart(SpringCamelContext.java:197)
	at
org.apache.camel.spring.SpringCamelContext.onApplicationEvent(SpringCamelContext.java:101)
	at
org.apache.camel.spring.CamelContextFactoryBean.onApplicationEvent(CamelContextFactoryBean.java:593)
	at
org.springframework.context.event.SimpleApplicationEventMulticaster$1.run(SimpleApplicationEventMulticaster.java:78)
	at
org.springframework.core.task.SyncTaskExecutor.execute(SyncTaskExecutor.java:49)
	at
org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:76)
	at
org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:274)
	at
org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:736)
	at
org.springframework.osgi.context.support.AbstractOsgiBundleApplicationContext.finishRefresh(AbstractOsgiBundleApplicationContext.java:235)
	at
org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext$4.run(AbstractDelegatedExecutionApplicationContext.java:358)
	at
org.springframework.osgi.util.internal.PrivilegedUtils.executeWithCustomTCCL(PrivilegedUtils.java:85)
	at
org.springframework.osgi.context.support.AbstractDelegatedExecutionApplicationContext.completeRefresh(AbstractDelegatedExecutionApplicationContext.java:320)
	at
org.springframework.osgi.extender.internal.dependencies.startup.DependencyWaiterApplicationContextExecutor$CompleteRefreshTask.run(DependencyWaiterApplicationContextExecutor.java:136)
	at java.lang.Thread.run(Thread.java:619)
Caused by: java.lang.ClassCastException: Not instanceof
org.apache.camel.TypeConverter value:
org.apache.camel.converter### @1474c1f
	at
org.apache.camel.impl.DefaultFactoryFinder.newInstance(DefaultFactoryFinder.java:103)
	at
org.apache.camel.impl.DefaultFactoryFinder.newInstance(DefaultFactoryFinder.java:93)
	at
org.apache.camel.impl.DefaultFactoryFinder.newInstances(DefaultFactoryFinder.java:64)
	at
org.apache.camel.impl.converter.DefaultTypeConverter.loadFallbackTypeConverters(DefaultTypeConverter.java:376)
	at
org.apache.camel.impl.converter.DefaultTypeConverter.loadTypeConverters(DefaultTypeConverter.java:366)
	at
org.apache.camel.impl.converter.DefaultTypeConverter.doStart(DefaultTypeConverter.java:384)
	at org.apache.camel.impl.ServiceSupport.start(ServiceSupport.java:53)
	at
org.apache.camel.util.ServiceHelper.startService(ServiceHelper.java:49)
	at
org.apache.camel.impl.DefaultCamelContext.startServices(DefaultCamelContext.java:1174)
	at
org.apache.camel.impl.DefaultCamelContext.addService(DefaultCamelContext.java:644)
	at
org.apache.camel.impl.DefaultCamelContext.getTypeConverter(DefaultCamelContext.java:691)
	... 20 more

KR,

Charles Moulliard

Senior Enterprise Architect (J2EE, .NET, SOA)
Apache Camel/ServiceMix Committer

*******************************************************************
- Blog : http://cmoulliard.blogspot.com
- Twitter : http://twitter.com/cmoulliard
- Linkedlin : http://www.linkedin.com/in/charlesmoulliard

     [
https://issues.apache.org/jira/browse...nels:all-tabpanel
]

Olga Natkovich updated PIG-1281:

Author: markt
Date: Wed Jun  2 15:12:36 2010
New Revision: 950587

URL: http://svn.apache.org/viewvc?rev=950587&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49099
Hooking the CoyoteAdaptor into the existing AccessLog wasn't as invasive
as I feared so go that route to log requests rejected by the Adaptor before
the request/response reaches the AcessLogValve

Added:
    tomcat/trunk/java/org/apache/catalina/AccessLog.java   (with props)
Modified:
    tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java
    tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java
    tomcat/trunk/webapps/docs/config/valve.xml

Added: tomcat/trunk/java/org/apache/catalina/AccessLog.java
URL:
http://svn.apache.org/viewvc/tomcat/t...587&view=auto

Author: markt
Date: Tue Jul  6 16:47:39 2010
New Revision: 960942

URL: http://svn.apache.org/viewvc?rev=960942&view=rev
Log:
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=49217
Make sure identifiers meet the requirements of the JLS

Modified:
    tomcat/trunk/java/org/apache/el/parser/AstDotSuffix.java
    tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java
    tomcat/trunk/java/org/apache/el/util/Validation.java
    tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/el/parser/AstDotSuffix.java
URL:
http://svn.apache.org/viewvc/tomcat/t...942&view=diff